Create interceptor for global features #8117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikalkan
reviewed
Mar 18, 2021
|
|
||
| namespace Volo.Abp.GlobalFeatures | ||
| { | ||
| public class AbpGlobalFeatureNotEnableException : AbpException, IHasErrorCode |
There was a problem hiding this comment.
Suggested change
| public class AbpGlobalFeatureNotEnableException : AbpException, IHasErrorCode | |
| public class AbpGlobalFeatureNotEnabledException : AbpException, IHasErrorCode |
There was a problem hiding this comment.
Also, please make the exception serializable (using constructor like the AbpException class)
| { | ||
| public static class GlobalFeatureHelper | ||
| { | ||
| public static bool IsGlobalFeatureEnabled(Type controllerType, out RequiresGlobalFeatureAttribute attribute) |
There was a problem hiding this comment.
Suggested change
| public static bool IsGlobalFeatureEnabled(Type controllerType, out RequiresGlobalFeatureAttribute attribute) | |
| public static bool IsGlobalFeatureEnabled(Type type, out RequiresGlobalFeatureAttribute attribute) |
controller is not a good naming in this layer.
|
I've merged this. Please make the improvement suggestions as another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #8108