Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cms Kit - Contents as markdown #8191

Merged
merged 9 commits into from Mar 26, 2021
Merged

Cms Kit - Contents as markdown #8191

merged 9 commits into from Mar 26, 2021

Conversation

enisn
Copy link
Member

@enisn enisn commented Mar 24, 2021

Summary

This PR provides to store contents as markdown in database and render it as html at public site.

@enisn enisn added this to the 4.3-preview milestone Mar 24, 2021
@enisn enisn requested review from ilkayilknur and cotur March 24, 2021 15:33
@enisn enisn self-assigned this Mar 24, 2021
ilkayilknur
ilkayilknur suggested changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@ilkayilknur ilkayilknur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We need to open the editor in Markdown mode on edit pages(page/blog post).
  • We need to generate the short description from HTML output.
    See
    image

@enisn enisn requested a review from ilkayilknur March 25, 2021 13:33
@enisn
Copy link
Member Author

enisn commented Mar 25, 2021

Fixed, can you review again @ilkayilknur ?

@ilkayilknur ilkayilknur merged commit 1f966f3 into dev Mar 26, 2021
@maliming maliming deleted the cms-kit/contents-as-markdown branch April 18, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilkayilknur ilkayilknur ilkayilknur approved these changes

@cotur cotur Awaiting requested review from cotur

Assignees

@enisn enisn

Labels
abp-module-cms-kit
Projects
None yet
Milestone
4.3-preview
Development

Successfully merging this pull request may close these issues.

CmsKit - Contents should be kept as markdown in database
2 participants
@enisn @ilkayilknur