Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Romanian language #9582

Merged
merged 6 commits into from Aug 3, 2021
Merged

Conversation

totpero
Copy link
Contributor

@totpero totpero commented Jul 13, 2021

No description provided.

@totpero totpero changed the title Add ro language Add Romanian language Jul 13, 2021
@berkansasmaz berkansasmaz self-requested a review July 13, 2021 13:29
@berkansasmaz berkansasmaz added this to the 5.0-preview milestone Jul 13, 2021
@berkansasmaz
Copy link
Member

Thank you very much for your contribution.

I will review your PR but before that, I have a few questions for you.

Would you like to contribute translations for our commercial ABP framework users? If you want, I can send you the necessary documents for this.

Also, can you send me the document where you run the abp translate --apply command? I need this document so that I can test the PR more smoothly and quickly, but if you don't have it, it's fine :)

@totpero
Copy link
Contributor Author

totpero commented Jul 14, 2021

Hi @berkansasmaz ,
I don't have the abp-translation.json file :).
Yes, i would like to contribute to the commercial version but,
I have one request, can you put this PR into 4.4-final milestone, if I finish all the translation (we need it for our new project)?

@berkansasmaz
Copy link
Member

berkansasmaz commented Jul 14, 2021

Unfortunately, I can't do that, because as you know we are not adding any new features to the 4.4-final milestone. Sorry for not being able to help with this :(

If you still want to contribute commercial localization documents, I leave the relevant document you will need.

abp-translation.json.zip

@berkansasmaz
Copy link
Member

I'm merging this PR, but if you decide to contribute translations for commercial, you can send the file to info@abp.io

Thanks again for your contribution.

@berkansasmaz berkansasmaz merged commit 41d1e8e into abpframework:dev Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants