Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CmsKit - Try to use Public Layout if presented by Theme #9813

Merged
merged 3 commits into from Sep 16, 2021

Conversation

enisn
Copy link
Member

@enisn enisn commented Aug 13, 2021

CmsKit Public pages should try to use Public layout if presented by theme.
Currently, developer must add _ViewStart.cshtml file into the end project

@enisn enisn added this to the 4.4-patch milestone Aug 13, 2021
@enisn enisn requested a review from hikalkan August 13, 2021 06:50
@enisn enisn self-assigned this Aug 13, 2021
@hikalkan
Copy link
Member

Please send PR to rel-4.4 branch.

@enisn enisn changed the base branch from dev to rel-4.4 August 13, 2021 06:52
@enisn
Copy link
Member Author

enisn commented Aug 16, 2021

It calls GetPublicLayout method and default value of fallbackToDefault is true. So it'll always fallback to default layout if public layout is not provided by theme:

public static string GetPublicLayout(this ITheme theme, bool fallbackToDefault = true)
{
return theme.GetLayout(StandardLayouts.Public, fallbackToDefault);
}

@ebicoglu ebicoglu modified the milestones: 4.4-patch, 5.0-preview Aug 31, 2021
@ebicoglu
Copy link
Member

we are releasing 4.4.1 today. I moved it to 5.0

@hikalkan hikalkan merged commit 939637d into rel-4.4 Sep 16, 2021
@hikalkan hikalkan deleted the enisn/rel-4.4/cms-kit-public-layout branch September 16, 2021 08:54
@enisn enisn modified the milestones: 5.0-preview, 4.4-patch Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants