Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular UI: Improved the build script in ng-packs #9875

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Angular UI: Improved the build script in ng-packs #9875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion npm/ng-packs/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
"extends": ["plugin:@nrwl/nx/typescript"],
"rules": {
"@typescript-eslint/no-namespace": "off",
"@typescript-eslint/no-empty-function": ["warn"]
"@typescript-eslint/no-empty-function": ["warn"],
"@typescript-eslint/no-empty-interface": ["warn"]
}
},
{
Expand Down
13 changes: 0 additions & 13 deletions npm/ng-packs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,18 +118,5 @@
"tslint": "~6.1.0",
"typescript": "~4.3.5",
"zone.js": "~0.11.4"
},
"dependencies": {
"@angular/animations": "^12.1.0",
"@angular/common": "^12.1.0",
"@angular/compiler": "^12.1.0",
"@angular/core": "^12.1.0",
"@angular/forms": "^12.1.0",
"@angular/platform-browser": "^12.1.0",
"@angular/platform-browser-dynamic": "^12.1.0",
"@angular/router": "^12.1.0",
"rxjs": "~6.6.0",
"tslib": "^2.0.0",
"zone.js": "~0.11.4"
}
}
2 changes: 1 addition & 1 deletion npm/ng-packs/scripts/build-schematics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ async function* copyPackageFiles(packageName: string) {
try {
await fse.remove(`../dist/packages/${PACKAGE_TO_BUILD}`);

await execa('yarn', ['install'], { cwd: '../packages/schematics' });
await execa('yarn', ['install'], { stdout: 'inherit', cwd: `../packages/${PACKAGE_TO_BUILD}` });

await execa(
'tsc',
Expand Down
3 changes: 3 additions & 0 deletions npm/ng-packs/scripts/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import program from 'commander';
import execa from 'execa';
import fse from 'fs-extra';

(async () => {
program.option('-i, --noInstall', 'skip updating package.json and installation', false);
Expand All @@ -12,6 +13,8 @@ import execa from 'execa';
await execa('yarn', ['install'], { stdout: 'inherit', cwd: '../' });
}

await fse.remove('../dist');

await execa(
'yarn',
[
Expand Down