Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow project names to contain but not equal to Blazor. #9948

Merged
merged 2 commits into from Sep 8, 2021
Merged

Allow project names to contain but not equal to Blazor. #9948

merged 2 commits into from Sep 8, 2021

Conversation

maliming
Copy link
Member

@maliming maliming commented Sep 2, 2021

Resolve #9853

@maliming maliming added this to the 5.0-preview milestone Sep 2, 2021
@ebicoglu
Copy link
Member

ebicoglu commented Sep 8, 2021

I refactored this.
We don't allow Blazor keyword because, Suite replaces Blazor keyword and project doesn't compile.

@ebicoglu ebicoglu merged commit a3a2dc0 into dev Sep 8, 2021
@ebicoglu ebicoglu deleted the maliming/IllegalKeywords branch September 8, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebicoglu ebicoglu ebicoglu approved these changes

Assignees
No one assigned
Labels
abp-cli
Projects
None yet
Milestone
5.0-preview
Development

Successfully merging this pull request may close these issues.

Allow project names to contain but not equal to Blazor.
2 participants
@maliming @ebicoglu