#11426 dashboard #110
Merged
#11426 dashboard #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added action named GetTopSellingAsync
Added an action named GetPercentOfTotaPayment for sales by payment method (Paypal, demo, etc). Still need development
Returns count of total order status for each one
to decrease calling service aggregated the 3 endpoints into GetDashboard endpoint
gterdem
suggested changes
May 4, 2022
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Include="..\EShopOnAbp.OrderingService.Domain\EShopOnAbp.OrderingService.Domain.csproj" /> | |||
| <ProjectReference Include="..\EShopOnAbp.OrderingService.Application.Contracts\EShopOnAbp.OrderingService.Application.Contracts.csproj" /> | |||
There was a problem hiding this comment.
This is not correct. EntityFrameworkCore layer shouldn't depend on Application.Contracts. See my comment for OrderingServiceRemoteServiceConsts.
Comment on lines
3
to
6
| public static class OrderingServiceRemoteServiceConsts | ||
| { | ||
| public const string RemoteServiceName = "Ordering"; | ||
| public const int Top10 = 10; |
There was a problem hiding this comment.
This is the wrong layer for domain-related constants. Constants should be under Domain.Shared especially when you are planning to use them on EntityFrameworkCore layer.
gterdem
approved these changes
May 5, 2022
...s/ordering/src/pages/dashboard/components/order-status-chart/order-status-chart.component.ts
Outdated
Show resolved
Hide resolved
.../projects/ordering/src/pages/dashboard/components/payments-chart/payments-chart.component.ts
Outdated
Show resolved
Hide resolved
.../projects/ordering/src/pages/dashboard/components/payments-chart/payments-chart.component.ts
Outdated
Show resolved
Hide resolved
muhammedaltug
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ordering dashboard implemented
closes abpframework/abp#11426