v3 to v4 API URI updates #44
Conversation
ghost
mentioned this pull request
| @@ -69,7 +69,7 @@ def exists? | |||
| project_id = get_project_id | |||
|
|
|||
| sshkey_hash = Hash.new | |||
| url = "#{gms_server}/api/v3/projects/#{project_id}/keys" | |||
| url = "#{gms_server}/api/v4/projects/#{project_id}/keys" | |||
There was a problem hiding this comment.
/api/v4/projects/#{project_id}/keys does not exist anymore, the correct path is /api/v4/projects/#{project_id}/deploy_keys now
There was a problem hiding this comment.
No problem, dont't forget to change this in the whole file ;)
|
@abrader any update on getting this merged it? it's all pretty broken at the moment. Thanks :) cc/ @alexizmailov |
|
Any update here @abrader ? |
|
Hi, also waiting for this one! |
|
+1 |
|
Yes still really keen to see this merged... |
I'm going to guess user's long term gone.... someone should probably fork and publish. |
|
@jstewart612 I will get to this PR as soon as I can. My apologies for the delay. Back on the road and no longer with Puppet. Appreciate your patience. |
|
@jas612 @sammcj @spluess @dannygoulder @alexizmailov Can anyone point me to the deprecation notice from GitHub for v3? |
|
@dannygoulder Thank you for sending that message. I guess I will have to make a note for users of this module who are still running older versions of GE to not use what will be the latest release 🤔 Anyone effectively test this change themselves? |
|
@abrader np, wasn't sure if you had moved on or anything. Cheers. I've been using the local fork and it hasn't broken yet, but I've not rigorously tested all use cases. |
|
Thanks @abrader, perhaps if you’re no longer using the project in the future it could be handed over to voxapupli? |
|
@abrader I am also using a local fork for debian9 systems and did not notice anything breaking, but I am only using this module with voxpupuli/puppet-gitlab. |
|
Glad I found this. With regards to backwards compatibility - is there a way to pass in the desired version of the API, and/or the version of Gitlab in use and programmatically set the version of the API? This isn't relevant to us (we've upgraded) - just thinking about it. Also, as posted in the issue, this didn't fully fix the issue for me. The keys endpoint now is deploy_keys per the transition doc: |
|
Thanks @abrader , just to clarify, we are talking gitlab and not github :-) |
|
Howdy, is this ready to be merged in yet? Currently it's breaking all our puppetmasters. |
|
Hi, checking in again to see what's happening with this, it's currently breaking all puppetmasters integrated with Gitlab. |
|
Also wanted to point out that I know there are users out there still using the v3 GitHub API so whatever the result of this PR ends up being, I think it's important to ensure things still work for v3 API users as well. |
This should fix the v3 git API deprecation issues.