Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BaseBlock as Block #31

Closed
Mayukhdeb opened this issue Feb 1, 2022 · 0 comments
Closed

Rename BaseBlock as Block #31

Mayukhdeb opened this issue Feb 1, 2022 · 0 comments
Assignees
@Mayukhdeb

Comments

@Mayukhdeb
Copy link
Member

Because it's not really a base class, but a publicly used class. So it just makes intuitive sense to name it that way.

The interface change would just be the fact that

from eden.block import BaseBlock
eden_block = BaseBlock()

becomes:

from eden.block import Block
eden_block = Block()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mayukhdeb Mayukhdeb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mayukhdeb