Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should fail when Karma has issues running tests #158

Closed
abraham opened this issue Jan 10, 2018 · 1 comment
Closed

CI should fail when Karma has issues running tests #158

abraham opened this issue Jan 10, 2018 · 1 comment

Comments

@abraham
Copy link
Owner

abraham commented Jan 10, 2018

Even with #157 having tests fail to run the CI passes. If the tests fail to run CI needs to fail.

https://circleci.com/gh/abraham/nutmeg-cli/259

10 01 2018 05:53:00.028:INFO [Firefox 47.0.0 (Linux 0.0.0)]: Connected on socket hzCZIQO9hf5qv7xGAAAB with id 80594156
WARN: 'Custom Elements: `Element#insertAdjacentElement` was not patched.'
Firefox 47.0.0 (Linux 0.0.0) ERROR
  {
    "message": "SyntaxError: missing = in const declaration\nat dist/ci-test.bundled.js:1579:19\n\n",
    "str": "SyntaxError: missing = in const declaration\nat dist/ci-test.bundled.js:1579:19\n\n"
  }

https://travis-ci.org/abraham/nutmeg-cli/jobs/327924488

12 01 2018 00:10:01.108:ERROR [launcher]: Cannot start ChromeHeadless
	[0112/001000.972590:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /opt/google/chrome/chrome-sandbox is owned by root and has mode 4755.
Failed to generate minidump.
12 01 2018 00:10:01.108:ERROR [launcher]: ChromeHeadless stdout: 
12 01 2018 00:10:01.108:ERROR [launcher]: ChromeHeadless stderr: [0112/001000.972590:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /opt/google/chrome/chrome-sandbox is owned by root and has mode 4755.
Failed to generate minidump.
12 01 2018 00:10:01.109:ERROR [launcher]: ChromeHeadless failed 2 times (cannot start). Giving up.
@abraham abraham added the bug label Jan 10, 2018
@abraham abraham changed the title CI doesn't fail when Karma has issues running tests CI should fail when Karma has issues running tests Jan 12, 2018
@abraham
Copy link
Owner Author

abraham commented Jan 13, 2018

Fix with #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant