Add Api host and Api Version by parameter, to support multiple (host …

[mahsanamin]

This addition will allow library to support any kind of Host, the main reason for now is to support the Ads Api URLs. I tried to keep it ad dynamic because it was less change and will allow the developers to think on their own regarding (Sandbox url and version). And this change will also leave system backward compatible.

The other important point is the addition of apiVersion inside http( method, I rearranged the parameter sequence because it is private method! and I think apiVersion should be in-front of host.

It was possible to follow the existing convention and put the URL as constant inside library but I think at this point we just need to add another flexibility to provide any host parameter and its handy to give Sanbox Url of Ads this way.

Note that I also added the test and tested those which works fine!

[abraham]

This isn't going to scale very well because it'll potentially need putWithHost, postWithHost, deleteWithHost, uploadWithHost, etc. I think a better approach would be to use child objects like this:

$to = new TwitterOAuth(...);
$to->ads->get(...);
$to->adsSandbox->get(...);

[mahsanamin]

Thank you Abraham for viewing it. I understand your concern! And I also saw your above code in your Github issues, I agree that it would be a very clean way to use your library but keeping backward compatibility may also be difficult.

Also it look like a little big change! The reason I did above way is to keep change as less as possible and still allow the support of Ads, at max we need to add two more small functions putWithHost, deleteWithHost which I didn't added because those were not available in Tag 0.5.3.

One note: you don't need upload method in case of Ads because the upload function is similar for twitter Ads!

[mahsanamin]

Abraham, I edited my comments above because those were little misleading and I had little confusion which I understand now! Let me know if you need my help to implement your way.

However I still feel that adding the methods like I did is the easiest way to add support of Ads and it won't be breaking!

Thank you!

[abraham]

Ads support will be planned for v2.

[abraham]

This is going to be handled in a more generic way in #684