Skip to content

Commit

Permalink
let RFP version pass
Browse files Browse the repository at this point in the history
  • Loading branch information
@abrahamjuliot
abrahamjuliot committed Aug 8, 2021
1 parent da3299b commit 0035c70
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion modules/features.js
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 comments on commit 0035c70

@Thorin-Oakenpants
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what you're letting pass here, but

  • why use reportedVersion (I assume parsed from userAgent) when you can just do a is78 or higher check - 1633836, 1589095, 1634135
  • why not also use a isRFP check as well
  • FF91+ will report 91 and at this stage FF104+ will report 104

@abrahamjuliot
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, this is a light CSS features test that determines if the worker scope ua version is near valid before sending ua samples to the server.

You are correct. I need to check isRFP. Actually, this should be sufficient.

Please sign in to comment.