Session: multisession and metadata #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CR nests multiple logins under one key. This is a nice property for operators because it keeps an individual's login session in one place instead of having to build a lookup index elsewhere mapping user->active sessions. It uses lazy deletion and expiration checks. There's a global expiration which exists for memcache or redis auto-expiration. There exists an inherent race if multiple sessions are being set at once. This race results in the last Set succeeding. In practice, an individual user shouldn't realistically be logging into two or more devices at the same time.
This CR adds a field to the session which enables storing additional optional metadata with the message. It's a byteslice so any data must be pre-serialized before getting stored into the backend. It can be retrieved through the ActiveSession method.
abraithwaite
commented
Sep 28, 2018
| @@ -25,7 +25,7 @@ type server struct { | |||
| var email = []byte("super@exa::mple.com") | |||
|
|
|||
| func (s *server) login(w http.ResponseWriter, r *http.Request) { | |||
| err := s.j.Set(r.Context(), w, email) | |||
| err := s.j.Set(r.Context(), w, email, []byte(r.UserAgent())) | |||
| @@ -26,6 +26,7 @@ details. | |||
| - CSRF Protection | |||
| - Context aware | |||
| - Fast | |||
| - Multiple sessions under one key | |||
| @@ -27,6 +27,9 @@ func (s *Store) Store(ctx context.Context, key, value []byte, exp time.Time) err | |||
|
|
|||
| func (s *Store) Fetch(ctx context.Context, key []byte) ([]byte, error) { | |||
| i, err := s.mc.Get(string(key)) | |||
| if err == memcache.ErrCacheMiss { | |||
There was a problem hiding this comment.
Satisfies the documented Fetch in the Storage interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.