update command to accept multiple fixtures. fixes #203

[Hypercubed]

This PR seperates out events from attaching files. The attachFile now accepts an array of fixtures. Each fixture is attached sequentually then the events are trigger.

Added tests and verified in recipes/angularjs-ng-file-upload.

Closes #203

[abramenal]

@Hypercubed thanks for submitting MR! Looks good 👍
I will need 1-2 days to add more tests to other frameworks to make sure it's being tested on every setup.

Also it is worth updating README.md with simple snippet to illustrate how this should work.

[abramenal]

@all-contributors add @Hypercubed for code

[allcontributors]

@abramenal

I've put up a pull request to add @Hypercubed! 🎉

[abramenal]

@Hypercubed unfortunately this is not working with react drag-n-drop. The reason is – before dataTransfer object contained all the files added, and for drag-n-drop case it triggered specific events with that dataTransfer object.
Right now every file gets attached separately, and then it cannot trigger valid event containing all the files

[Hypercubed]

I'm not sure I undetstand what you mean by "cannot trigger valid event containing all the files". Does this mean it break react drag-n-drop entirely or only when passing multiple fixtures. I wonder if it ever work with the older version.

[abramenal]

It breaks entirely regardless of files count. You can reproduce it when running examples/react-dropzone repo tests – there you can tweak import 'cypress-file-upload' to use your local version import '../../../../src/index'.

I planned to look into it this weekend, but feel free to investigate if you have time.

[tommy-anderson]

Hey there, @abramenal , @Hypercubed any idea when this will happen?

Our project relies heavily on uploading files and we just started updating from cypress 4.12.1 to cypress 6.4.1 so naturally need to update the cypress-file-upload plugin. Would hate to leave the the mulitple-images upload test cases hanging.

Sadly I don't have enough technical background to dive into the issues myself.

[abramenal]

Hi @tommy-anderson,
I know this is painful, really appreciate your patience on that.

I see @paulblyth submitted a PR, I am happy to look at it during weekend. Hopefully this will work just fine so I can release it quickly. Will keep this PR posted as well.

[abramenal]

#251 is merged, so closing this one. Thanks anyways, appreciate your effort and welcome to the contributors list ❤️