Split command to 'attachFile' using 'cy.readFile' and 'attachFixture' using 'cy.fixture' #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abramenal can you please review it? |
|
@abramenal can you please check this? |
abramenal
reviewed
Oct 19, 2021
| @@ -0,0 +1,10 @@ | |||
| import { wrapBlob } from './common'; | |||
|
|
|||
| export default function getFileContent({ filePath, fileContent, fileEncoding }) { | |||
There was a problem hiding this comment.
Function name should match the file name
| ``` | ||
|
|
||
| It is a common practice to put all the files required for Cypress tests inside `cypress/fixtures` folder and call them as fixtures (or a fixture). The command recognizes [`cy.fixture`][cy.fixture] format, so usually this is just a file name. | ||
| It is a common practice to put all the files required for Cypress tests inside `cypress/fixtures` folder and call them as fixtures (or a fixture). `attachFixture` command recognizes [`cy.fixture`][cy.fixture] format, so usually this is just a file name. `attachFile` on the other hand recognise [`cy.readFile`][cy.readFile], so full file path is needed. `optionalProcessingConfig` is the same for both commands. |
There was a problem hiding this comment.
Suggested change
| It is a common practice to put all the files required for Cypress tests inside `cypress/fixtures` folder and call them as fixtures (or a fixture). `attachFixture` command recognizes [`cy.fixture`][cy.fixture] format, so usually this is just a file name. `attachFile` on the other hand recognise [`cy.readFile`][cy.readFile], so full file path is needed. `optionalProcessingConfig` is the same for both commands. | |
| It is a common practice to put all the files required for Cypress tests inside `cypress/fixtures` folder and call them as fixtures (or a fixture). `attachFixture` command recognizes [`cy.fixture`][cy.fixture] format, so usually this is just a file name. `attachFile` on the other hand recognise [`cy.readFile`][cy.readFile], so a path within the project root folder is needed. `optionalProcessingConfig` is the same for both commands. |
Copying this from cy.readFile docs. First got confused as thought it can also accept global file path
|
@all-contributors add @ErikGrigoriev for code |
|
I've put up a pull request to add @ErikGrigoriev! 🎉 |
|
@ErikGrigoriev one thing I am a bit unsure of is – whether to allow raw file contents to be passed. With this kind of separation it might make sense to create a separate command for that, so:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Summary of changes
Added possibility to upload file instead of fixture. Split to 2 different commands. Renamed actual
attachFiletoattachFixtureand reworkedattachFileto usecy.readFileinstead. Would force existing users to rename all their usages toattachFixturein order to use it as before, but according to new functionality this naming seems to be more precise.Linked issues
Closes #232
Comment
Main reason for introducing this is bug this bug from cypress itself. Using fixture for upload failed in our project since we were creating files with same name for upload. And even though files were deleted and recreated between tests, cached data was used causing upload inconsistency.