Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor mode: don't fail starting up without network #257

Closed
norbusan opened this issue Nov 30, 2018 · 5 comments
Closed

monitor mode: don't fail starting up without network #257

norbusan opened this issue Nov 30, 2018 · 5 comments
Assignees
Labels
Bug Something isn't working Fixed

Comments

@norbusan
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

If running via systemd and being offline, onedrive dies with "No network connection to Microsoft OneDrive Service" and the systemd reset counter is increased:

Scheduled restart job, restart counter is at 21.

This is by itself not a real problem, but I somehow dislike these permanent restarts and thought about whether we can deal with that more gracefully, in the same way we deal now with missing network during monitor mode based sync.

Describe the solution you'd like
As long as there is a token available, go as far as possible, and then retry in the usual intervals to connect and sync.

I will look into the code.

@abraunegg
Copy link
Owner

@norbusan
No problem - thanks

@abraunegg abraunegg added Bug Something isn't working In Progress Currently being worked on labels Dec 3, 2018
@abraunegg
Copy link
Owner

This should be resolved by PR #266 - can you confirm?

@abraunegg abraunegg added Fixed and removed In Progress Currently being worked on labels Dec 4, 2018
@norbusan
Copy link
Collaborator Author

norbusan commented Dec 4, 2018

Well, this was what I was testing during development. I will recheck with the current code base after all the merges.

@norbusan
Copy link
Collaborator Author

norbusan commented Dec 4, 2018

Confirmed, closing.

@norbusan norbusan closed this as completed Dec 4, 2018
@lock
Copy link

lock bot commented Jan 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Fixed
Projects
None yet
Development

No branches or pull requests

2 participants