Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Better handling of the addopts option for pytest #98

Closed
abravalheri opened this issue Apr 19, 2024 · 0 comments · Fixed by #100
Closed

[FR] Better handling of the addopts option for pytest #98

abravalheri opened this issue Apr 19, 2024 · 0 comments · Fixed by #100

Comments

@abravalheri
Copy link
Owner

abravalheri commented Apr 19, 2024

Currently, if the value of the option contains comments in multiple lines the conversion will result in an invalid config.

Probably an alternative is to split the lines and then split each line using shlex.split
As per pytest-dev/pytest#12228, the pytest maintainers recommend addopts to be a string, so we should probably strip the comments.

@abravalheri abravalheri changed the title [FR] Better handler of the addopts option for pytest [FR] Better handling of the addopts option for pytest Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant