Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Avasam <samuel.06@hotmail.com>
  • Loading branch information
abravalheri and Avasam committed Apr 30, 2024
1 parent 50214b6 commit 352ea19
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions mypy.ini
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ exclude = (?x)(
| ^.tox/
| ^.egg/
| ^pkg_resources/tests/data/my-test-package-source/setup.py$ # Duplicate module name
| ^pkg_resources/_vendor/ # Vendored
| ^setuptools/_vendor/ # Vendored
| /_vendor/ # Vendored
| ^setuptools/_distutils/ # Vendored
| ^setuptools/config/_validate_pyproject/ # Auto-generated
)
Expand All @@ -23,8 +22,8 @@ exclude = (?x)(
disable_error_code = attr-defined

[mypy-pkg_resources._vendor.*,setuptools._vendor.*,setuptools.config._validate_pyproject.*,setuptools.tests.*]
# Even when excluded there might be problems: python/mypy/issues/11936#issuecomment-1466764006
# - Avoid raising issues when importing from "_vendor" modules
# Even when excluded there might be problems: https://github.com/python/mypy/issues/11936#issuecomment-1466764006
# - Avoid raising issues when importing from vendored modules
# - Avoid raising issues when importing dependencies in tests
follow_imports = silent
# silent => ignore errors when following imports
Expand Down

0 comments on commit 352ea19

Please sign in to comment.