Make sure namespace packages obtained via import finder handle later additions to path #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
changed the base branch from
editable-link-tree
to
editable-link-tree2
abravalheri
force-pushed
the
editable-fix-namespaces
branch
from
18ea4e6
to
e2135d5
Compare
2 tasks
abravalheri
force-pushed
the
editable-link-tree2
branch
from
63b4b42
to
546605c
Compare
abravalheri
force-pushed
the
editable-fix-namespaces
branch
from
e2135d5
to
d931716
Compare
abravalheri
force-pushed
the
editable-link-tree2
branch
from
546605c
to
9c527cd
Compare
abravalheri
force-pushed
the
editable-fix-namespaces
branch
from
d931716
to
3434415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the PEP 420, namespace packages need to gracefully handle later additions to path.
See https://discuss.python.org/t/pep-660-and-setuptools/14855/15
Summary of changes
PathEntryFinder+ an arbitrary placeholder entry onsys.pathto forcePathFinderto create a namespace spec._NamespacePathand_NamespaceLoaderare private classes (or just documented for comparison purposes), there is no other way to implement this behaviour directly1.Closes
Pull Request Checklist
changelog.d/.(See documentation for details)
Footnotes
Reimplementing
_NamespacePath+ a custom logic to maintain namespace portions don't have a corresponding path entry also seems to have the same end result. ↩