Improve validation of attr directives for setuptools (#101)

abravalheri · May 18, 2023 · b8db58b · b8db58b
1 parent b7bcae2
commit b8db58b
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/src/validate_pyproject/plugins/setuptools.schema.json b/src/validate_pyproject/plugins/setuptools.schema.json
@@ -256,7 +256,7 @@
       "type": "object",
       "additionalProperties": false,
       "properties": {
-        "attr": {"type": "string"}
+        "attr": {"format": "python-qualified-identifier"}
       },
       "required": ["attr"]
     },

diff --git a/tests/invalid-examples/setuptools/attr/missing-attr-name.errors.txt b/tests/invalid-examples/setuptools/attr/missing-attr-name.errors.txt
@@ -0,0 +1,2 @@
+`tool.setuptools.dynamic.version` must be valid exactly by one definition
+'attr': {format: 'python-qualified-identifier'}
diff --git a/tests/invalid-examples/setuptools/attr/missing-attr-name.toml b/tests/invalid-examples/setuptools/attr/missing-attr-name.toml
@@ -0,0 +1,17 @@
+# Issue pypa/setuptools#3928
+# https://github.com/RonnyPfannschmidt/reproduce-setuptools-dynamic-attr
+[build-system]
+build-backend = "_own_version_helper"
+backend-path = ["."]
+requires = ["setuptools" ]
+
+[project]
+name = "ronnypfannschmidt.setuptools-build-attr-error-reproduce"
+description = "reproducer for a setuptools issue"
+requires-python = ">=3.7"
+dynamic = [
+  "version",
+]
+
+[tool.setuptools.dynamic]
+version = { attr = "_own_version_helper."}