Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: schemastore conversion script #119

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Oct 13, 2023

This is the script I'm using to prepare the schema for SchemaStore:

SchemaStore/schemastore#3307

When producing that, I've applied #117 and #116 as well.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@abravalheri abravalheri merged commit 036f26f into abravalheri:main Oct 23, 2023
29 checks passed
@henryiii henryiii deleted the henryiii/chore/schemastore branch October 23, 2023 16:57
@abravalheri
Copy link
Owner

Thank you very much! Should we add a test to make sure all changes in the schemas will always generate a SchemaStore-compliant script after the pre-processing? Is that something relatively easy to achieve?

@henryiii
Copy link
Collaborator Author

Hmm, actually, it probably could be set up in CI pretty easily. The procedure is something like:

git checkout <schemastore>
git checkout <validate-pyproject>
cd validate-pyproject
./tools/to_schemastore.py src/validate_pyproject/plugins/setuptools.schema.json > ../schemastore/src/schemas/json/setuptools.json
cd ../schemastore/src
npm install
npm run grunt # -- --SchemaName=pyproject.json
# Note: checking just one schema (commented above) doesn't seem to work as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants