Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing blacken-docs pre-commit hook #2

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Fix failing blacken-docs pre-commit hook #2

merged 2 commits into from
Feb 1, 2022

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Feb 1, 2022

No description provided.

@abravalheri
Copy link
Owner

Thank you very much @hukkin.

hooks:
- id: blacken-docs
additional_dependencies: [black]
additional_dependencies: [black==22.1.0]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any incompatibility with some versions, or you are just following the recommendations from the docs?

Now that black is becoming stable, with a clear update/deprecation policy, could we rely on the latest version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just following the recommendation from the docs. Note that if we don't pin black version, then we should probably just delete this additional_dependencies line. black is required by blacken-docs anyways, just not version pinned.

Black's policy still allows formatting changes at the start of a new year, so one sensible alternative is pinning black==22.*.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the clarification!

@abravalheri abravalheri merged commit 73b8729 into abravalheri:main Feb 1, 2022
@abravalheri
Copy link
Owner

Thanks @hukkin, I merged your PR into master and I will adopt your suggestion about black==22.* in a separated commit.

@hukkin hukkin deleted the patch-2 branch February 1, 2022 15:08
@abravalheri abravalheri mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants