Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks #40

Merged
merged 3 commits into from
May 16, 2022
Merged

Add pre-commit hooks #40

merged 3 commits into from
May 16, 2022

Conversation

wwuck
Copy link
Contributor

@wwuck wwuck commented May 9, 2022

Add two pre-commit hooks, one with all dependencies included

Fixes #39

add two pre-commit hooks, one with all dependencies included

Fixes #39
@abravalheri
Copy link
Owner

abravalheri commented May 9, 2022

Thank you very much @wwuck. How about we just add the one with .[all]? I think validate-pyproject-minimal would have some problems due to the missing tomli dependency (I left it out of the default set of dependencies because most of the libraries related to packaging vendor their own version of toml, e.g. setuptools).

(I think pre-commit wraps each hook in its own virtual environment, right? So there would be no problems with collisions).

@wwuck
Copy link
Contributor Author

wwuck commented May 13, 2022

Ok thanks for the review. I've removed the minimal hook.

@abravalheri abravalheri merged commit 5eeb787 into abravalheri:main May 16, 2022
@wwuck wwuck deleted the feature/pre-commit-hook branch May 17, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pre-commit hook for validate-pyproject
2 participants