Improve trove classifier validation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
force-pushed
the
improve-trove-classifier-problem
branch
from
763bc3e
to
5644e5f
Compare
abravalheri
force-pushed
the
improve-trove-classifier-problem
branch
from
1a2d670
to
0e0967b
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when embedded
validate-pyprojectwill require users to addtrove-classifiersto their dependencies. In some scenarios (e.g.setuptools) that may be very annoying (see comment in https://discuss.python.org/t/help-testing-experimental-features-in-setuptools/13821/21).A possible alternative is to download the classifiers directly from PyPI if the package is not installed, this is done by both
distutilsandflit.This change adds the download as a fallback mechanism, but also skip this validation if the
NO_NETWORKenvironment variable is used or if the download fails.