test portability tests #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new test file that checks that each of the portability tests catch bad files. Add a private accessor for `%bad_names` for testing purposes (some refactoring might be in order, but this works for now).
|
I've taken over the patch as is for now as the accessor usage is bike shedding and the tests are very important as the 0.08 fallout has shown. |
|
Creating this PR completely escapes my memory. Glad it was helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new test file that checks that each of the portability tests
catch bad files. Add a private accessor for
%bad_namesfor testingpurposes (some refactoring might be in order, but this works for now).
I am on a Windows machine, and so could not test that the symlink
test runs and passes, so please do so before mergin.