New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test portability tests #4

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@garfieldnate
Contributor

garfieldnate commented Apr 23, 2015

Add a new test file that checks that each of the portability tests
catch bad files. Add a private accessor for %bad_names for testing
purposes (some refactoring might be in order, but this works for now).

I am on a Windows machine, and so could not test that the symlink
test runs and passes, so please do so before mergin.

test portability tests
Add a new test file that checks that each of the portability tests
catch bad files. Add a private accessor for `%bad_names` for testing
purposes (some refactoring might be in order, but this works for now).
@abraxxa

This comment has been minimized.

Owner

abraxxa commented Dec 31, 2017

I've taken over the patch as is for now as the accessor usage is bike shedding and the tests are very important as the 0.08 fallout has shown.
I've also added the File::Temp test requirement which was missing in your pull-request.
Thanks for your contribution!

@abraxxa abraxxa closed this Dec 31, 2017

@garfieldnate

This comment has been minimized.

Contributor

garfieldnate commented Dec 31, 2017

Creating this PR completely escapes my memory. Glad it was helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment