Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider cycleway:left&right in onewaypenalty #268

Merged

Conversation

Totorrr
Copy link
Contributor

@Totorrr Totorrr commented Sep 25, 2020

Avoids discarding some fine ways during routing

Fabien added 2 commits September 25, 2020 15:28
Avoids discarding some fine ways during routing
Consider cycleway:left&right in onewaypenalty
Avoids discarding some fine ways during routing
@Phyks
Copy link
Contributor

Phyks commented May 16, 2021

Hi! This should be done as well in #123 for the trekking profile, along with many other improvements. Happy to have any feedback on this one (positive or negative) and especially on whether it could supersede this one or fails on some cases. Thanks!

@zod zod added the profiles label Nov 20, 2021
@Totorrr
Copy link
Contributor Author

Totorrr commented Oct 21, 2022

Would you be willing to pull @abrensch @afischerdev @zod ?

@afischerdev
Copy link
Collaborator

You are right, there are some outstanding profile changes.

I'm willing to add this - nice, has no conflicts on the first view.
But I see an other pending request #245 that like to deal with the same ideas.
Please have a look there if this changes fit your needs.
As you will see the #245 has conflicts with other profiles, so I would like to clear that first and merge it then.

@afischerdev afischerdev merged commit 609f62d into abrensch:master Apr 2, 2023
afischerdev added a commit to afischerdev/brouter that referenced this pull request Apr 2, 2023
@afischerdev afischerdev mentioned this pull request Apr 2, 2023
afischerdev added a commit that referenced this pull request Apr 2, 2023
@Totorrr Totorrr deleted the profiles-oneway-bicycle-leftright branch June 12, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants