Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More PMD rules & fixes #550

Merged
merged 3 commits into from
May 15, 2023
Merged

More PMD rules & fixes #550

merged 3 commits into from
May 15, 2023

Conversation

zod
Copy link
Collaborator

@zod zod commented May 9, 2023

Android Studio displays a lot of warnings for our current code. I've tried to find some PMD rules which cover the same issues to tackle them and prevent them from reappearing in the codebase.

@zod zod temporarily deployed to BRouter May 9, 2023 21:13 — with GitHub Actions Inactive
@zod zod requested a review from afischerdev May 15, 2023 06:42
@afischerdev
Copy link
Collaborator

@zod
I have that in mind. But I'm waiting for the #549 to have not to much rework.

May be it is a good way to have such reformatting around a tagged version in the future. So it's many predefined code around.

@zod
Copy link
Collaborator Author

zod commented May 15, 2023

It causes just one simple conflict with #549, so I don't think that should delay the merge.

@afischerdev afischerdev merged commit 8bf0125 into abrensch:master May 15, 2023
1 check passed
@zod zod deleted the pmd-fixes branch May 15, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants