Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup hgt reader #553

Merged
merged 3 commits into from
May 17, 2023
Merged

Cleanup hgt reader #553

merged 3 commits into from
May 17, 2023

Conversation

zod
Copy link
Collaborator

@zod zod commented May 15, 2023

It seems like #548 was merged in a hurry without a proper cleanup.

  • It sill contained unused (and GPL licensed) HgtReader.java
  • Duplicated code in zipped/unzipped hgt reading

This PR still lacks handling of 1 arc second file merging into .bef.

@zod zod requested a review from afischerdev May 15, 2023 19:42
@zod zod temporarily deployed to BRouter May 15, 2023 19:42 — with GitHub Actions Inactive
@zod zod temporarily deployed to BRouter May 15, 2023 19:46 — with GitHub Actions Inactive
@afischerdev
Copy link
Collaborator

This PR still lacks handling of 1 arc second file merging into .bef.

I didn't get this run with 3arc as well.
What is the special naming on the conveter?
Is this 'bef' format still needed?

@zod
Copy link
Collaborator Author

zod commented May 16, 2023

I think the idea is to replace the CSI CGIAR SRTM files with lidar sources, therefore the first argument is the filename of srtm file (doesn't need to exist, just to get lon/lat).

I've tested it using

java -cp brouter-1.6.3/brouter-1.6.3-all.jar btools.mapcreator.ConvertLidarTile srtm_38_03.zip sonny/3asec

and it reads N44E004.zip ... N50E010.zip from sonny/3asec folder and creates srtm_38_03.bef

@afischerdev
Copy link
Collaborator

@zod
Yes, I already did ...ConvertLidarTile srtm_38_03.zip ....
But I did it with my iceland.pbf and picked out the bef names from output. Generated the bef files - small change of the e/w format logic only -, generated Iceland again.
No results for elevation on route generation. And only three of the bef files are read - protocol says.
I think there are more problems in code. But I'll stop investigation for now.. HGT file import works.

@afischerdev afischerdev merged commit 11a9843 into abrensch:master May 17, 2023
1 check passed
@zod zod deleted the elev-source-cleanup branch May 17, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants