Updated test.py for assessing Item.time

[chaconnewu]

Making sure it will not raise an exception when Item.time is assessed.

[abrinsmead]

This test is ok the way it is because either Item(1) has a time attribute or, if it doesn't, your fix prevents any problems. :)

What I was looking for is a test that proves that an item that is known to be without a time attribute does not cause an error. I would do something like this...

def test_item_without_time_attribute_can_be_created:
    item_id_without_time = 9999999  # need to find an actual item without time attribute
    item = self.hn.item(item_id_without_time)
    self.assertIsInstance(item, Item)

Thanks for your help!

[chaconnewu]

No problem! Do you have any other plan with this project?

On Tue, Nov 4, 2014 at 11:03 PM, Alex Brinsmead notifications@github.com
wrote:

This test is ok the way it is because either Item(1) has a time attribute
or, if it doesn't, your fix prevents any problems. :)

What I was looking for is a test that proves that an item that is known to
be without a time attribute does not cause an error. I would do something
like this...

def test_item_without_time_attribute_can_be_created:
item_id_without_time = 9999999 # need to find an actual item without time attribute
item = self.hn.item(item_id_without_time)
self.assertIsInstance(item, Item)

Thanks for your help!

—
Reply to this email directly or view it on GitHub
#2 (comment)
.

Wu Yu

[abrinsmead]

There is not much more to do until the next version of the Hacker News API is released.

But I do have some other open source and paid projects that you might be interested in. Please send me an email to alex.brinsmead@dataloft.com. Thanks!