Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding golang/dep #30

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

nmengin
Copy link

@nmengin nmengin commented Sep 19, 2017

Adding the new tool golang/dep for the libkv project.
This tool allows dependencies management.

Fix versions for dependencies as constraints or overrides when necessary.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.124% when pulling 307f97f on nmengin:feature/add-go-dep into 0c1d214 on abronan:master.

@abronan
Copy link
Owner

abronan commented Sep 19, 2017

Hi @nmengin, thank you for the PR!

I tried to avoid using any dependency management on the libkv side because I think it is better handled on the side of projects using the library (using dep/glide/godep/etc.). It is true that this is annoying because of occasional breakage of client libraries (for example recently with etcd/client and ugorji/go, although I submitted a change upstream in etcd to fix that).

I'm not against including this change but I'm not sure this is entirely necessary either (considering the small scale of the project).

Thoughts?

@abronan
Copy link
Owner

abronan commented Sep 19, 2017

Also it's broken on the CI somehow.

@nmengin
Copy link
Author

nmengin commented Sep 19, 2017

Ok @abronan.

I just did it in the way to compile the master branch and submit you PR about ETCD management.
I let you close this PR.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.124% when pulling a90e52c on nmengin:feature/add-go-dep into 0c1d214 on abronan:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.124% when pulling 174070b on nmengin:feature/add-go-dep into 0c1d214 on abronan:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants