meta: Standardize results of List call for every backend #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abronan
commented
Oct 10, 2017
store/zookeeper/zookeeper.go
Outdated
| c = strings.TrimSuffix(directory, "/") + "/" + c | ||
| err := s.listChildrenRecursive(list, c) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Missing: We should ignore the error if the key is ephemeral (zk.ErrNoChildrenForEphemerals) here.
abronan
force-pushed
the
meta_list_fix
branch
from
d40978b
to
6192a44
Compare
…ing an empty list if the key given in entry has no child. The modifications are done on ETCD V2,V3, BoltDB and Redis stores.
List is used to list child keys of a directory, whether
recursively over the entire tree and subfolders or just
direct childs.
Results from the List calls where inconsistent on every
backend, some would return the direct children while others
would return the recursive result by default, some backends
would include the directory key in the result, etc.
This PR normalizes the result of the List call to be the
same on every store for the recursive version.
For example, considering this tree:
parent/
parent/child
parent/subfolder
parent/subfolder/child1
parent/subfolder/child2
parent/subfolder/child3
If we call 'List' on "parent", the result of the List call
will be:
parent/child
parent/subfolder
parent/subfolder/child1
parent/subfolder/child2
parent/subfolder/child3
Signed-off-by: Alexandre Beslic <abeslic@abronan.com>
abronan
force-pushed
the
meta_list_fix
branch
from
6192a44
to
5d363b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carry #32
List is used to list child keys of a directory, whether
recursively over the entire tree and subfolders or just
direct childs.
Results from the List calls where inconsistent on every
backend, some would return the direct children while others
would return the recursive result by default, some backends
would include the directory key in the result, etc.
This PR normalizes the result of the List call to be the
same on every store for the recursive version.
For example, considering this tree:
If we call 'List' on "parent", the result of the List call
will be:
Signed-off-by: Alexandre Beslic abeslic@abronan.com