etcd: remove mutex side keys from results in List
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the lock key is given in entry
abronan
force-pushed
the
filter_lock_key
branch
3 times, most recently
from
d3bc7b8
to
8355a31
Compare
This PR completes the work done on aligning the results returned by `List` by filtering `*_lock` keys from the results. Additionally, we test for this case for both etcd v2 and etcd v3 and we change the lock suffix to be `___lock` instead of `_lock` to avoid collision with similar key names following the pattern of using a simple underscore (might brake backward compatibility of `List` results for client the using master version of libkv). Signed-off-by: Alexandre Beslic <abeslic@abronan.com>
abronan
force-pushed
the
filter_lock_key
branch
from
8355a31
to
20331a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carry and completes #31
This PR aligns the results returned by
Listby filtering*_lockkeys from the results.Additionally, we test for this case for both etcd v2 and etcd v3 and we change the lock suffix to be
___lockinstead of_lockto avoid collision with similar key names following the pattern of using a simple underscore (might brake backward compatibility ofListresults for client the using master version of libkv).@nmengin PTAL :)