Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix import statements in etcd.go again. Update etcdv3 client. #40

Merged
merged 1 commit into from May 12, 2020

Conversation

Gaboose
Copy link
Contributor

@Gaboose Gaboose commented May 12, 2020

This seems to fix a panic where duplicate enum is attempted to be
registered with protobuf:

goroutine 1 [running]:
github.com/golang/protobuf/proto.RegisterEnum(...)
        /home/gabrielius/go/pkg/mod/github.com/golang/protobuf@v1.3.3/proto/properties.go:458
github.com/coreos/etcd/auth/authpb.init.0()
        /home/gabrielius/go/pkg/mod/github.com/coreos/etcd@v3.3.13+incompatible/auth/authpb/auth.pb.go:103 +0x1b7

If etcd client is imported twice under different names (go.etcd.io/etcd
and github.com/coreos/etcd).

This seems to fix a panic where duplicate enum is attempted to be
registered with protobuf:

```
goroutine 1 [running]:
github.com/golang/protobuf/proto.RegisterEnum(...)
        /home/gabrielius/go/pkg/mod/github.com/golang/protobuf@v1.3.3/proto/properties.go:458
github.com/coreos/etcd/auth/authpb.init.0()
        /home/gabrielius/go/pkg/mod/github.com/coreos/etcd@v3.3.13+incompatible/auth/authpb/auth.pb.go:103 +0x1b7
```

If etcd client is imported twice under different names (go.etcd.io/etcd
and github.com/coreos/etcd).
Copy link
Member

@abronan abronan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That issue is really annoying and is serious enough to get people in trouble with the broken versioning. So LGTM. We can change this properly to use 3.5.0 when it is out.

@abronan abronan merged commit 2b7603e into kvtools:master May 12, 2020
@Gaboose
Copy link
Contributor Author

Gaboose commented May 20, 2020

Issues blocking the 3.5.0 release for easy reference: https://github.com/etcd-io/etcd/milestone/37

@tooolbox tooolbox mentioned this pull request Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants