Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uReport fails with a package version mismatching the expected regex #1025

Closed
genodeftest opened this issue Jan 8, 2023 · 4 comments
Closed

Comments

@genodeftest
Copy link

When trying to report a bug on my current Fedora 37 installation, I see the following message (in GNOME Abrt):

--- Running report_uReport ---
Server responded with an error: 'List element is invalid: Element 'version' is invalid: String '20201206^1.git0c78c8329' does not match the pattern  '^[a-zA-Z0-9_\.\+~]+$''
('report_uReport' exited with 1)

It seems like the cause for this are the following binary packages:

$ rpm -qa | grep 20201206
google-noto-fonts-common-20201206^1.git0c78c8329-7.fc37.noarch
google-noto-naskh-arabic-vf-fonts-20201206^1.git0c78c8329-7.fc37.noarch
google-noto-sans-gurmukhi-vf-fonts-20201206^1.git0c78c8329-7.fc37.noarch
google-noto-sans-math-fonts-20201206^1.git0c78c8329-7.fc37.noarch
google-noto-sans-mono-vf-fonts-20201206^1.git0c78c8329-7.fc37.noarch
google-noto-sans-vf-fonts-20201206^1.git0c78c8329-7.fc37.noarch
google-noto-serif-vf-fonts-20201206^1.git0c78c8329-7.fc37.noarch

which are built from the source package google-noto-fonts.

This should not happen. Either Fedora must not allow these strings as package versions (but it does, in reality) or libreport must accept this version string.

Version info:

$ rpm -q libreport abrt
libreport-2.17.4-1.fc37.x86_64
abrt-2.15.1-6.fc37.x86_64

This issue is seen by other users too, e.g. @mcatanzaro in this pagure ticket comment.

PS: I am not sure whether this is the correct place to report this issue. Please give me hints if you think this location is incorrect.

@msrb
Copy link
Member

msrb commented Jan 9, 2023

Thanks for the bug report. I think this is a bug in faf as ^ characters are allowed in Fedora. Although they don't seem to be very common.

@mgrabovsky Do you know if simply adding the caret character to the regex here would be enough to fix this issue?

@mgrabovsky
Copy link
Contributor

@msrb From a quick glimpse, I'd say yes, that should fix the problem here.

@mgrabovsky mgrabovsky transferred this issue from abrt/retrace-server Jan 10, 2023
mgrabovsky added a commit that referenced this issue Jan 10, 2023
The [Fedora packaging guidelines][1] require a caret to be used in the
version string for package snaphots.

[1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

Fixes #1025
mgrabovsky added a commit that referenced this issue Jan 10, 2023
The [Fedora packaging guidelines][1] require a caret to be used in the
version string for package snaphots.

[1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

Fixes #1025
mgrabovsky added a commit that referenced this issue Jan 10, 2023
The [Fedora packaging guidelines][1] require a caret to be used in the
version string for package snaphots.

[1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

Fixes #1025
@mgrabovsky
Copy link
Contributor

The fix has now been deployed to retrace.fedoraproject.org.

@genodeftest
Copy link
Author

Thank you very much for this quick fix! I've already tested it and can confirm that it is working fine now (the exact same crash I wanted to report 3 days ago now can be reported just fine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants