Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added travis integration #24

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Conversation

illseption
Copy link
Contributor

Changes:

  • Added .travis.yml file

The build is currently failing and this might need to be fixed in another issue

@sammy1997
Copy link

Hey @illseption ! I see that you are using .sh scripts from a project. We can't ensure the trustability of the source and also don't know if it's regularly maintained. I would suggest adding the required steps in the .yml itself than running a bash script from another project. @eshaan7 Thoughts?

@illseption
Copy link
Contributor Author

Okay, what tests should I add? I'm calling the other project because it provides easy linting of the code. We could maybe use coala if maintenance is an issue?

@sammy1997
Copy link

I meant that you can directly add the dependencies and installation commands in travis yml file. We don't need a separate service for that

@eshaan7 eshaan7 linked an issue Mar 18, 2020 that may be closed by this pull request
@eshaan7
Copy link
Member

eshaan7 commented Mar 18, 2020

I don't think there's a problem with using the script from another repo. If any issue comes in the feature, we can handle it then. So I will be merging this now.

@eshaan7 eshaan7 merged commit 7f6edfc into abs0lut3pwn4g3:gssoc20-dev Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI, Linting, Formatting
3 participants