Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlinedVector is not exception-safe #32

Closed
stephan-tolksdorf opened this issue Oct 12, 2017 · 1 comment
Closed

InlinedVector is not exception-safe #32

stephan-tolksdorf opened this issue Oct 12, 2017 · 1 comment

Comments

@stephan-tolksdorf
Copy link

The insert and emplace methods of InlinedVector don't seem to protect at all against the construction of a new element throwing after existing elements have been moved. If this happens, the vector may be left with uninitialized gaps in the middle of a vector, which will lead to undefined behaviour when e.g. the vector's destructor runs.

@JonathanDCohen
Copy link
Contributor

JonathanDCohen commented Oct 16, 2017

Please see my comments in #33 and #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants