identifiers non-prefixed with absl

[Sarcasm]

Looking at the code, I can see some identifiers aren't using the absl namespace.
I'm mostly thinking about some defines/macros, not C++ classes/functions.

For example, there is:

• LOCKABLE
• ANNOTATE_CONTIGUOUS_CONTAINER
• DYNAMIC_ANNOTATIONS_ENABLED

Is it a bug or a feature?

Personally, I would expect ABSL_LOCKABLE instead of LOCKABLE.

[zhangxy988]

They are not prefixed with ABSL_ intentionally. Respectively:

• LOCKABLE: We use the naming in https://clang.llvm.org/docs/ThreadSafetyAnalysis.html. We don't expect this macro to have any definition conflict with other macros. Let me guess, are you having problem with a enum named LOCKABLE?
• ANNOTATE_CONTIGUOUS_CONTAINER: These are widely-adopted ASAN macros that we don't want to rename.
• DYNAMIC_ANNOTATIONS_ENABLED: This is a build switch to enable dynamic annotations. We don't think it's necessary to rename it, because if user has -DDYNAMIC_ANNOTATIONS_ENABLED they probably want -DABSL_DYNAMIC_ANNOTATIONS_ENABLED too.

[Sarcasm]

Let me guess, are you having problem with a enum named LOCKABLE?

No :),
I just assumed it was an accepted convention that libraries should not use generic names.
This kind of things works only if one library do it.

Also I don't see any downside to ABSL_LOCKABLE.

Anyway, if it is on purpose, I will close this ticket, I assumed it was there by accident.

Thanks for you answer.