Make it work with sqlalchemy>=1.4.0 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add test workflow * Fix flaky test: Sleep one sec after first commit so that the second commit does not happen the same second * Use SkipTest to get rid of <TestResult has no addExpectedFailure method, reporting as passes>
…here's a better way to get _entity_zero, I haven't spent any time looking
|
@michaelbukachi so this is a priority, SQLAlchemy 1.4 is already released. |
|
|
Hey @flying-sheep, do you mind testing off the master branch? I'll create a release if no issues are found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I have had to do to make it work with sqlalchemy 1.4.0b1