Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling Dataloader.get on a value that wasn't loaded raises an error #52

Closed
axelson opened this issue Sep 26, 2018 · 2 comments
Closed

Calling Dataloader.get on a value that wasn't loaded raises an error #52

axelson opened this issue Sep 26, 2018 · 2 comments

Comments

@axelson
Copy link

axelson commented Sep 26, 2018

Writing this up as discussed in our Slack discussion, although I'm not sure it is a bug per se.

I think this may be just a change in behavior that should be documented as a breaking change (in 1.0.3). I'll prepare a PR to that effect.
@benwilson512
Copy link
Contributor

Ah yeah definitely not a bug if it wasn't already loaded. Trying to do a get for something that wasn't already there was never really supported, it just didn't happen to return an error before.

@axelson
Copy link
Author

axelson commented Sep 26, 2018

Yup, makes total sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axelson @benwilson512