Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ecto sandbox when using Ecto.Multi #130

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
51 changes: 51 additions & 0 deletions test/dataloader/ecto/multi_async_test.exs
@@ -0,0 +1,51 @@
defmodule Dataloader.Ecto.MultiAsyncTest do
use ExUnit.Case, async: true

alias Dataloader.User
alias Dataloader.TestRepo, as: Repo

setup do
:ok = Ecto.Adapters.SQL.Sandbox.checkout(Repo)

test_pid = self()

source =
Dataloader.Ecto.new(
Repo,
query: &query(&1, &2, test_pid)
)

loader =
Dataloader.new()
|> Dataloader.add_source(Test, source)

{:ok, loader: loader}
end

defp query(schema, _params, test_pid) do
send(test_pid, :querying)

schema
end

test "loads data", %{loader: loader} do
user =
%User{username: "Ben Wilson"}
|> Repo.insert!()

result =
Ecto.Multi.new()
|> Ecto.Multi.run(:loader, fn _, _ ->
loader =
loader
|> Dataloader.load(Test, User, user.id)
|> Dataloader.run()

{:ok, loader}
end)
|> Repo.transaction()

assert {:ok, %{loader: loader}} = result
assert user == Dataloader.get(loader, Test, User, user.id)
end
end
52 changes: 52 additions & 0 deletions test/dataloader/ecto/multi_sync_test.exs
@@ -0,0 +1,52 @@
defmodule Dataloader.Ecto.MultiSyncTest do
use ExUnit.Case, async: false

alias Dataloader.User
alias Dataloader.TestRepo, as: Repo

setup do
:ok = Ecto.Adapters.SQL.Sandbox.checkout(Repo)
:ok = Ecto.Adapters.SQL.Sandbox.mode(Repo, {:shared, self()})

test_pid = self()

source =
Dataloader.Ecto.new(
Repo,
query: &query(&1, &2, test_pid)
)

loader =
Dataloader.new()
|> Dataloader.add_source(Test, source)

{:ok, loader: loader}
end

defp query(schema, _params, test_pid) do
send(test_pid, :querying)

schema
end

test "loads data", %{loader: loader} do
user =
%User{username: "Ben Wilson"}
|> Repo.insert!()

result =
Ecto.Multi.new()
|> Ecto.Multi.run(:loader, fn _, _ ->
loader =
loader
|> Dataloader.load(Test, User, user.id)
|> Dataloader.run()

{:ok, loader}
end)
|> Repo.transaction()

assert {:ok, %{loader: loader}} = result
assert user == Dataloader.get(loader, Test, User, user.id)
end
end