Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update telemetry dependency to stable ~> 1.0 #132

Merged
merged 2 commits into from Aug 24, 2021
Merged

Update telemetry dependency to stable ~> 1.0 #132

merged 2 commits into from Aug 24, 2021

Conversation

bmuller
Copy link
Contributor

@bmuller bmuller commented Aug 24, 2021 •
edited

There were no changes in the Telemetry 1.0.0 release - but it does represent the first "stable" version of the API.

benwilson512
benwilson512 requested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@benwilson512 benwilson512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this an or so that it maintains compatibility.

mix.exs Outdated Show resolved Hide resolved
@benwilson512 benwilson512 merged commit 91db9e4 into absinthe-graphql:master Aug 24, 2021
@bmuller bmuller deleted the update-telemetry-dependency branch August 24, 2021 17:39
@bmuller bmuller mentioned this pull request Aug 24, 2021
Merged
@edennis
Copy link

edennis commented Sep 27, 2021

Any chance at a version bump to include this?

@krainboltgreene
Copy link

Jumping in here because phoenix 1.6 released with telemetry 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwilson512 benwilson512 benwilson512 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bmuller @edennis @krainboltgreene @benwilson512 @deepankar-j