Avoid preloads in lateral subqueries #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ecto doesn't allow preloads in subqueries This change moves the preloads out to a call to Repo.preload. This should support basic keyword preloads, but join preloads are dropped.
|
Would be super helpful to merge this @benwilson512 when you get the chance to review it. |
|
Great stuff, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #97
Ecto doesn't allow preloads in subqueries, so this PR moves any preloads out to a call to
Repo.preload.This should support basic keyword preloads, but join preloads are dropped.
It also avoids using a lateral join when loading rows by primary key with a limit, as in the example in #97.