NOISSUE - Abstract list data-structure on input form #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmuchyri
requested changes
Dec 18, 2023
rodneyosodo
requested changes
Dec 19, 2023
ianmuchyri
requested changes
Dec 19, 2023
|
It shouldn't reflect if a user presses the enter button without having any data as shown below Those dots are if I press the enter button without having any tags |
|
for some reason now, I can't delete the tags by clicking on them |
ianmuchyri
requested changes
Dec 19, 2023
rodneyosodo
requested changes
Dec 19, 2023
|
There is no more color |
|
also check why in this modal, it does not work as intended. I cannot see the tags at the top |
ianmuchyri
reviewed
Dec 21, 2023
ianmuchyri
requested changes
Dec 21, 2023
|
Please rebase. |
Signed-off-by: SammyOina <sammyoina@gmail.com>
…s to a list using the Enter key. Signed-off-by: SammyOina <sammyoina@gmail.com>
The package-lock.json file had an incorrect version of prettier. This commit fixes the version to "^3.1.0" to ensure compatibility with the project dependencies. Signed-off-by: SammyOina <sammyoina@gmail.com>
The commit fixes a styling issue in the listUtils.js file by adding a margin-bottom class to the newly created list item. This ensures proper spacing between list items. In addition, the commit also addresses a styling issue in the domains.html file. The commit modifies the class attribute of a div element to ensure proper alignment within a row. These changes improve the overall visual consistency and user experience. Signed-off-by: SammyOina <sammyoina@gmail.com>
The deleteItem function in listUtils.js was not working properly due to unnecessary code. Removed the unnecessary code and fixed the bug. Also, removed an extra line in bootstraps.html. This commit addresses the above issues. Signed-off-by: SammyOina <sammyoina@gmail.com>
The commit fixes a bug in the listUtils.js file where an empty input value was being added as a list item. The bug is fixed by adding a condition to check if the input value is not empty before creating a new list item. Signed-off-by: SammyOina <sammyoina@gmail.com>
The deleteItem function in listUtils.js was not correctly checking for the class name "highlight-list-item" when deleting an item. This has been fixed by using the classList.contains method instead of comparing the className directly. Signed-off-by: SammyOina <sammyoina@gmail.com>
Co-authored-by: Ian Ngethe Muchiri <100555904+ianmuchyri@users.noreply.github.com>
Co-authored-by: Ian Ngethe Muchiri <100555904+ianmuchyri@users.noreply.github.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
The button class in listUtils.js was updated to "btn btn-primary" to match the styling of other buttons. In navbar.html, an id attribute was added to the "domain-tags" input element. Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
The commit fixes the class name of the button in listUtils.js. The previous class name "btn-primary" has been changed to "body-button". This ensures consistency with the rest of the codebase and improves readability. Signed-off-by: SammyOina <sammyoina@gmail.com>
Standardize and clarify tag-related variable names in HTML templates for things and users. Renamed 'tags' to 'thingsTags' and 'userTags' to mitigate ambiguity across different features where tag systems are utilized. These changes improve code readability and maintain a consistent naming convention. Signed-off-by: SammyOina <sammyoina@gmail.com>
@dborovcanin I have rebased |
1 similar comment
@dborovcanin I have rebased |
rodneyosodo
requested changes
Jan 11, 2024
Updates use tables it's a bit different and would require a separate PR |
Can you create an issue for that |
dborovcanin
approved these changes
Jan 11, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Allows input of list items in a user-friendly way without revealing the underlying datastructure
Which issue(s) does this PR fix/relate to?
None
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes
This could also be used for metadata input