MG-2201 - Fail role update if user does not exist (#2234)

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
absmach · Jun 12, 2024 · 6cabc23 · 6cabc23
1 parent 487dcc6
commit 6cabc23
Show file tree

Hide file tree

Showing 2 changed files with 236 additions and 154 deletions.
diff --git a/users/service.go b/users/service.go
@@ -383,9 +383,14 @@ func (svc service) UpdateClientRole(ctx context.Context, token string, cli mgcli
 		UpdatedBy: tokenUserID,
 	}
 
+	if _, err := svc.authorize(ctx, auth.UserType, auth.UsersKind, client.ID, auth.MembershipPermission, auth.PlatformType, auth.MagistralaObject); err != nil {
+		return mgclients.Client{}, err
+	}
+
 	if err := svc.updateClientPolicy(ctx, cli.ID, cli.Role); err != nil {
 		return mgclients.Client{}, err
 	}
+
 	client, err = svc.clients.UpdateRole(ctx, client)
 	if err != nil {
 		// If failed to update role in DB, then revert back to platform admin policy in spicedb