Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add property based testing to twins API #2098

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

rodneyosodo
Copy link
Member

What type of PR is this?

This is a feature PR as it adds property-based testing to twins API. In addition it is a refactor to error handling on the API

What does this do?

Adds schemathesis to twins service

Which issue(s) does this PR fix/relate to?

No issue

Have you included tests for your changes?

Yes, I have included tests for my changes.

Did you document any new/modified feature?

No

Notes

To be merged after #2096

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
@dborovcanin dborovcanin merged commit f334ee2 into absmach:main Apr 16, 2024
3 of 6 checks passed
JeffMboya added a commit to JeffMboya/magistrala that referenced this pull request Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

NOISSUE - Add property based testing to twins API (absmach#2098)

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya added a commit to JeffMboya/magistrala that referenced this pull request Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

NOISSUE - Add property based testing to twins API (absmach#2098)

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya added a commit to JeffMboya/magistrala that referenced this pull request Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add mockery directive to CI

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Revert changes

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Refactor endpoints_test.go to use generated mocks

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Remove unused fmt.Printf statement in listMessagesEndpoint function

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

NOISSUE - Add property based testing to twins API (absmach#2098)

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya added a commit to JeffMboya/magistrala that referenced this pull request Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add mockery directive to CI

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Revert changes

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Refactor endpoints_test.go to use generated mocks

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Remove unused fmt.Printf statement in listMessagesEndpoint function

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

NOISSUE - Add property based testing to twins API (absmach#2098)

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya added a commit to JeffMboya/magistrala that referenced this pull request Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add mockery directive to CI

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Revert changes

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Refactor endpoints_test.go to use generated mocks

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Remove unused fmt.Printf statement in listMessagesEndpoint function

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

NOISSUE - Add property based testing to twins API (absmach#2098)

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya added a commit to JeffMboya/magistrala that referenced this pull request Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add mockery directive to CI

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Revert changes

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Refactor endpoints_test.go to use generated mocks

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Remove unused fmt.Printf statement in listMessagesEndpoint function

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

NOISSUE - Add property based testing to twins API (absmach#2098)

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
dborovcanin pushed a commit to JeffMboya/magistrala that referenced this pull request Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add mockery directive to CI

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Revert changes

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Refactor endpoints_test.go to use generated mocks

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Remove unused fmt.Printf statement in listMessagesEndpoint function

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

NOISSUE - Add property based testing to twins API (absmach#2098)

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya added a commit to JeffMboya/magistrala that referenced this pull request Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Add mockery directive to CI

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Revert changes

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Refactor endpoints_test.go to use generated mocks

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Remove unused fmt.Printf statement in listMessagesEndpoint function

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

NOISSUE - Add property based testing to twins API (absmach#2098)

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Generate mocks with mockery for readers

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya pushed a commit to JeffMboya/magistrala that referenced this pull request May 15, 2024
Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
JeffMboya pushed a commit to JeffMboya/magistrala that referenced this pull request May 15, 2024
Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants