-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Add property based testing to twins API #2098
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3a15e3
to
c3ba2b3
Compare
cbd3ca2
to
5359e47
Compare
088af4b
to
b1e1fe3
Compare
b1e1fe3
to
f34859c
Compare
dborovcanin
approved these changes
Apr 16, 2024
Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
f34859c
to
59642ef
Compare
JeffMboya
added a commit
to JeffMboya/magistrala
that referenced
this pull request
Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com> NOISSUE - Add property based testing to twins API (absmach#2098) Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya
added a commit
to JeffMboya/magistrala
that referenced
this pull request
Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com> NOISSUE - Add property based testing to twins API (absmach#2098) Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya
added a commit
to JeffMboya/magistrala
that referenced
this pull request
Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Add mockery directive to CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Revert changes Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Refactor endpoints_test.go to use generated mocks Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Remove unused fmt.Printf statement in listMessagesEndpoint function Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> NOISSUE - Add property based testing to twins API (absmach#2098) Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya
added a commit
to JeffMboya/magistrala
that referenced
this pull request
Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Add mockery directive to CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Revert changes Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Refactor endpoints_test.go to use generated mocks Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Remove unused fmt.Printf statement in listMessagesEndpoint function Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> NOISSUE - Add property based testing to twins API (absmach#2098) Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya
added a commit
to JeffMboya/magistrala
that referenced
this pull request
Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Add mockery directive to CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Revert changes Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Refactor endpoints_test.go to use generated mocks Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Remove unused fmt.Printf statement in listMessagesEndpoint function Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> NOISSUE - Add property based testing to twins API (absmach#2098) Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya
added a commit
to JeffMboya/magistrala
that referenced
this pull request
Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Add mockery directive to CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Revert changes Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Refactor endpoints_test.go to use generated mocks Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Remove unused fmt.Printf statement in listMessagesEndpoint function Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> NOISSUE - Add property based testing to twins API (absmach#2098) Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
dborovcanin
pushed a commit
to JeffMboya/magistrala
that referenced
this pull request
Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Add mockery directive to CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Revert changes Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Refactor endpoints_test.go to use generated mocks Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Remove unused fmt.Printf statement in listMessagesEndpoint function Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> NOISSUE - Add property based testing to twins API (absmach#2098) Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya
added a commit
to JeffMboya/magistrala
that referenced
this pull request
Apr 16, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Add mockery directive to CI Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Revert changes Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Refactor endpoints_test.go to use generated mocks Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Remove unused fmt.Printf statement in listMessagesEndpoint function Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> NOISSUE - Add property based testing to twins API (absmach#2098) Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com> Generate mocks with mockery for readers Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
JeffMboya
pushed a commit
to JeffMboya/magistrala
that referenced
this pull request
May 15, 2024
Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
JeffMboya
pushed a commit
to JeffMboya/magistrala
that referenced
this pull request
May 15, 2024
Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature PR as it adds property-based testing to twins API. In addition it is a refactor to error handling on the API
What does this do?
Adds schemathesis to twins service
Which issue(s) does this PR fix/relate to?
No issue
Have you included tests for your changes?
Yes, I have included tests for my changes.
Did you document any new/modified feature?
No
Notes
To be merged after #2096