Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix links in README.md file #2129

Merged
merged 7 commits into from
Apr 3, 2024

Conversation

dborovcanin
Copy link
Collaborator

@dborovcanin dborovcanin commented Mar 29, 2024

What type of PR is this?

This is a chore pull request addressing some links and updates in README.md and some other minor fixes.

What does this do?

This pull request updates links in README files and provides smaller updates in the root README file. It also updates some testing dependencies.

Which issue(s) does this PR fix/relate to?

There is no such issue.

Have you included tests for your changes?

N/A

Did you document any new/modified feature?

N/A

Notes

N/A

@dborovcanin dborovcanin changed the title NOISSUE - Fix links in READMEmd file NOISSUE - Fix links in README.md file Mar 29, 2024
drasko
drasko previously approved these changes Mar 29, 2024
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remove GPL3-licenced test dependencies

Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change:

  • emails on api docs
  • smpp readme at consumers/notifiers/smpp/README.md

Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dborovcanin dborovcanin merged commit a39d462 into absmach:main Apr 3, 2024
5 of 6 checks passed
@dborovcanin dborovcanin deleted the readme-licnese branch April 3, 2024 09:55
VeddySama pushed a commit to VeddySama/magistrala that referenced this pull request Apr 3, 2024
Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Apr 4, 2024
Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Apr 5, 2024
Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Apr 7, 2024
Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants