MG-2071 - Rename viewer relation #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagamunene
changed the title
nyagamunene
force-pushed
the
MG-2071-RenameViewerRelation
branch
2 times, most recently
from
5b6c20c
to
6cf308a
Compare
rodneyosodo
requested changes
May 28, 2024
arvindh123
requested changes
May 30, 2024
There was a problem hiding this comment.
@nyagamunene
Rename only Viewer relation to contributor and don't change the view permission to contribution , Please keep it as view
arvindh123
reviewed
May 30, 2024
arvindh123
reviewed
May 30, 2024
arvindh123
requested changes
Jun 4, 2024
nyagamunene
force-pushed
the
MG-2071-RenameViewerRelation
branch
2 times, most recently
from
91aef93
to
7257872
Compare
arvindh123
requested changes
Jun 10, 2024
arvindh123
approved these changes
Jun 10, 2024
nyagamunene
force-pushed
the
MG-2071-RenameViewerRelation
branch
2 times, most recently
from
460e91f
to
adc9386
Compare
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
dborovcanin
force-pushed
the
MG-2071-RenameViewerRelation
branch
from
adc9386
to
f504b00
Compare
dborovcanin
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This a feature because it rename viewer relation to contributor since he can not only view but also edit.
What does this do?
It renames the
ViewerRelationtoContributorRelationandViewPermissiontoContributePermission.Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes
Did you document any new/modified feature?
Yes
Notes