MG-2287 - Improve Search For Users #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagamunene
force-pushed
the
MG-2287-ImproveSearch
branch
2 times, most recently
from
1b50d92
to
5e2f5dd
Compare
nyagamunene
changed the title
nyagamunene
force-pushed
the
MG-2287-ImproveSearch
branch
from
45047cf
to
c658d37
Compare
nyagamunene
force-pushed
the
MG-2287-ImproveSearch
branch
from
c658d37
to
4deeb31
Compare
nyagamunene
force-pushed
the
MG-2287-ImproveSearch
branch
from
cfad1f0
to
519761f
Compare
dborovcanin
requested changes
Jun 28, 2024
nyagamunene
force-pushed
the
MG-2287-ImproveSearch
branch
from
27aed8a
to
6bad357
Compare
dborovcanin
requested changes
Jun 30, 2024
dborovcanin
requested changes
Jul 1, 2024
cli/users.go
Outdated
| { | ||
| Use: "search <query> <user_auth_token>", | ||
| Short: "Search users", | ||
| Long: "Search users by name, id or identity\n" + |
There was a problem hiding this comment.
Use username instead of identity here.
SammyOina
requested changes
Jul 1, 2024
pkg/sdk/go/users.go
Outdated
| @@ -321,6 +321,25 @@ func (sdk mgSDK) ListUserThings(userID string, pm PageMetadata, token string) (T | |||
| return tp, nil | |||
| } | |||
|
|
|||
| func (sdk mgSDK) SearchUsers(pm PageMetadata, token string) (UsersPage, errors.SDKError) { | |||
There was a problem hiding this comment.
how does this method differe from the Users method. since both call the same repository method, retrieve basic info and both have the same function signature, it is redundant
There was a problem hiding this comment.
I don't think so. It is calling search endpoint which calls the searchBasicInfo method
There was a problem hiding this comment.
ok, but the methods RetrieveAllBasicInfo and SearchBasicInfo are functionally simillar why do they have to be distinct functions
There was a problem hiding this comment.
There is a slight difference on how we construct the query. Also the RetrieveAllBasicInfo is supposed to be remove later from the conversation we had with @arvindh123. Initially I was to rename it to searchBasicInfo but it was agreed to keep it as it is and create the method seperately searchBasicInfo
There was a problem hiding this comment.
It is not the same, but we should RetrieveBasicInfo in ListClients in case the user is not an admin. @nyagamunene
nyagamunene
force-pushed
the
MG-2287-ImproveSearch
branch
from
82c5749
to
26e0a9a
Compare
SammyOina
approved these changes
Jul 1, 2024
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
dborovcanin
force-pushed
the
MG-2287-ImproveSearch
branch
from
b1a8108
to
909a367
Compare
dborovcanin
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it improve search for Users.
What does this do?
This enables back-end support for filtering by name.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests for my changes.
Did you document any new/modified feature?
No. I have not updated the documentation because it will be done in a different PR
Notes