Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After yarn release minor version doesn't increase #25

Closed
santyas opened this issue Jun 11, 2022 · 4 comments
Closed

After yarn release minor version doesn't increase #25

santyas opened this issue Jun 11, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@santyas
Copy link

santyas commented Jun 11, 2022

Hello!

Im trying to increase my changelog with my conventional commits.

Configured from: https://commitlint.js.org/#/guides-local-setup?id=install-commitlint

Always increase last numbers 0.1.XX

I want to get X.X.XX

Environment

  • npx create-next-app@latest --typescript
  • commit-and-tag-version 10.0.1
    @commitlint/cli
    @commitlint/config-conventional
    husky

The commit message after yarn release is always the same: chore release and 0.1.xx... It doesn't matter if you commit a feat or breaking change.

Captura de Pantalla 2022-06-11 a la(s) 16 03 07

@santyas santyas added the bug Something isn't working label Jun 11, 2022
@santyas
Copy link
Author

santyas commented Jun 11, 2022

Well, if it starts from 1.0.0 works! But the commit message keep printing 'chore(release): 1.1.1'

@TimothyJones
Copy link
Member

Below version 1, semver has no definition for what the version number means. I can't see any breaking changes in the screenshot you linked - but I think the behaviour is for the minor version to increase on breaking changes, and for patch versions to increase for everything else.

From version 1.0.0 onwards, semver should apply and you should see the version number increasing correctly.

But the commit message keep printing 'chore(release): 1.1.1'

I'm not sure what you mean by this - that looks right to me. Can you give more details on your setup and what you're expecting?

@santyas
Copy link
Author

santyas commented Jun 13, 2022

@TimothyJones Excellent, I will start an example with 1.0.0. Thanks.

Second thing, nevermind. It's possible to custimize it from .versionrc

@santyas santyas closed this as completed Jun 13, 2022
@TimothyJones
Copy link
Member

See also this comment: #26 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants