Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a single function,
replace_non_ascii
, that replaces non-Ascii values with a specified value. Although I have more string pre-processing functions I am interested in contributing, since this is my first pull request, I wanted to keep it small :). It also adds a test_str2.py file and a benchmarks folder to generate benchmark data, run benchmarks, and plot / run analytics on the benchmarks.Thanks for the great library and please let me know if this is a good / bad PR! Thanks a lot!